You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/01/04 03:14:34 UTC
[GitHub] ShannonDing commented on a change in pull request #51: be able to
build examples with static client
ShannonDing commented on a change in pull request #51: be able to build examples with static client
URL: https://github.com/apache/rocketmq-client-cpp/pull/51#discussion_r245191851
##########
File path: example/CMakeLists.txt
##########
@@ -49,11 +49,11 @@ foreach(file ${files})
${Boost_LIBRARIES} ${LIBEVENT_LIBRARIES} ${JSONCPP_LIBRARIES})
endif()
else()
- #if (BUILD_ROCKETMQ_SHARED)
+ if (BUILD_ROCKETMQ_SHARED)
target_link_libraries (${basename} rocketmq_shared ${deplibs})
- #else()
- # target_link_libraries (${basename} rocketmq_static ${deplibs})
- #endif()
+ else()
+ target_link_libraries (${basename} rocketmq_static ${deplibs} ${Boost_LIBRARIES} ${LIBEVENT_LIBRARIES} ${JSONCPP_LIBRARIES})
Review comment:
I think boost libraries, libevent, and jsonncpp library don't need to be linked again, as they are linked to rocketmq_static before.
Could you please remove "${Boost_LIBRARIES} ${LIBEVENT_LIBRARIES} ${JSONCPP_LIBRARIES}" and have a test on it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services