[GitHub] [carbondata] kunal642 commented on a change in pull request #4089: [CARBONDATA-4117][[CARBONDATA-4123] cg index and bloom index query issue with Index server

[GitBox <gi...@apache.org>]

kunal642 commented on a change in pull request #4089:
URL: https://github.com/apache/carbondata/pull/4089#discussion_r576809083



##########
File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletIndexFactory.java
##########
@@ -110,9 +111,15 @@ public BlockletIndexFactory(CarbonTable carbonTable, IndexSchema indexSchema) {
    * @param carbonTable
    * @return
    */
-  public static Index createIndex(CarbonTable carbonTable) {
+  public static Index createIndex(CarbonTable carbonTable) throws IOException {
     boolean cacheLevelBlock = BlockletIndexUtil.isCacheLevelBlock(carbonTable);
-    if (cacheLevelBlock) {
+    boolean hasBloomIndex = false;

Review comment:
       better to have a check for cg datamap also in serialize data method..
   
   If(blockcache && cg.isEmty) {dont write blocklet details} else {write blocklet details}




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org