You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/16 18:08:26 UTC

[GitHub] [pulsar] bharanic-dev commented on pull request #11582: [Issue 11581][broker] feat:pass the executor to RateLimiter in ResourceGroupPublishLimiter

bharanic-dev commented on pull request #11582:
URL: https://github.com/apache/pulsar/pull/11582#issuecomment-899712433


   @leizhiyuan Thank you for taking care of this. Passing the Executor was one of the tasks in my TODO list (which I why I left the comment in the code). Glad you were able to get to it before I could.
   
   Just to clarify though, I don't think this addresses any flaky tests. The flaky tests reported in:
   https://github.com/apache/pulsar/issues/11096
   https://github.com/apache/pulsar/pull/11601
   
   are because of a code issue, where the zookeeper watch events were getting fixed. The race condition was reported in #11157 and fixed in #11198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org