You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/04/07 06:32:05 UTC
[jira] [Created] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Removed unused internal methods from DistributedCache
-----------------------------------------------------
Key: MAPREDUCE-2422
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: client
Reporter: Tom White
Assignee: Tom White
DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2422:
---------------------------------
Attachment: MAPREDUCE-2422.patch
Minor update to remove unused imports.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2422:
---------------------------------
Attachment: MAPREDUCE-2422.patch
New patch to add a (@Private) ClientDistributedCacheManager, which is used by the client-side job submission process.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2422:
---------------------------------
Status: Patch Available (was: Open)
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027824#comment-13027824 ]
Todd Lipcon commented on MAPREDUCE-2422:
----------------------------------------
OK, I looked through this in some more detail and agree with your assessment. +1
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017151#comment-13017151 ]
Hadoop QA commented on MAPREDUCE-2422:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12475726/MAPREDUCE-2422.patch
against trunk revision 1089686.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/157//console
This message is automatically generated.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016771#comment-13016771 ]
Hadoop QA commented on MAPREDUCE-2422:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12475663/MAPREDUCE-2422.patch
against trunk revision 1089686.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/156//console
This message is automatically generated.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2422:
---------------------------------
Attachment: MAPREDUCE-2422.patch
Here's a patch to remove the dependency that DistributedCache has on TrackerDistributedCacheManager.
* Removed (deprecated, @Private) internal methods that are no longer used. TaskDistributedCacheManager and TrackerDistributedCacheManager are already being used internally.
* Moved implementation of checkURIs back to DistributedCache, since it is a client-side user method.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030186#comment-13030186 ]
Hudson commented on MAPREDUCE-2422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #659 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/659/])
MAPREDUCE-2422. Removed unused internal methods from DistributedCache.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026078#comment-13026078 ]
Todd Lipcon commented on MAPREDUCE-2422:
----------------------------------------
It looks like most of these deprecated methods that are being removed were only deprecated in 0.21. As I understand it, the community has decided that we can't remove these until after the next *stable* release (i.e 0.21 didn't count as a release as far as API removal goes). Do you think that, instead of removing these methods, we could keep them around as simple forwarding stubs?
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2422:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I've just committed this.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026098#comment-13026098 ]
Tom White commented on MAPREDUCE-2422:
--------------------------------------
These methods are all internal methods, not user facing ones. They are marked as such in the javadoc (and in retrospect we should have marked them as @Private). This change would be in the 0.23 release, which seems reasonable to me.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025549#comment-13025549 ]
Hadoop QA commented on MAPREDUCE-2422:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477441/MAPREDUCE-2422.patch
against trunk revision 1096649.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/186//console
This message is automatically generated.
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2422) Removed unused internal methods
from DistributedCache
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031225#comment-13031225 ]
Hudson commented on MAPREDUCE-2422:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #675 (See [https://builds.apache.org/hudson/job/Hadoop-Mapreduce-trunk/675/])
> Removed unused internal methods from DistributedCache
> -----------------------------------------------------
>
> Key: MAPREDUCE-2422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2422
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: client
> Reporter: Tom White
> Assignee: Tom White
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2422.patch, MAPREDUCE-2422.patch, MAPREDUCE-2422.patch
>
>
> DistributedCache has a number of deprecated methods that are no longer used ever since TrackerDistributedCacheManager was introduced in MAPREDUCE-476. Removing these methods (which are not user-facing) will make it possible to complete MAPREDUCE-1638 by keeping DistributedCache in the API tree, and TrackerDistributedCacheManager, TaskDistributedCacheManager in the implementation tree.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira