[GitHub] [incubator-druid] leventov opened a new issue #3771: Implement LookupExtractor.close() and avoid deleting off-heap cache while LookupExtractor is in use

[GitBox <gi...@apache.org>]

leventov opened a new issue #3771: Implement LookupExtractor.close() and avoid deleting off-heap cache while LookupExtractor is in use
URL: https://github.com/apache/incubator-druid/issues/3771
 
 
   Addressing https://github.com/druid-io/druid/blob/78159d7ca442cf8d99ea356d39932ab3adb8e10f/extensions-core/lookups-cached-global/src/main/java/io/druid/server/lookup/namespace/cache/OffHeapNamespaceExtractionCacheManager.java#L122
   
   Proposed solution: make `LookupExtractor` closeable, and remove the cache only after it is replaced by a newer cache via periodic updates, _and_ there are no open `LookupExtractor`s accessing this cache. (Implementation may require some kind of manual reference counting.)
   
   Currently, because of #3663, while off-heap cache is not functional, so this issue is not important because "closing" on-heap cache while using it is harmless ("closing" is just cleaning references to it, the cache itself is unchanged.)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org