Re: [PR] [CELEBORN-914] Support memory file storage [celeborn]

["ErikFang (via GitHub)" <gi...@apache.org>]

ErikFang commented on code in PR #2300:
URL: https://github.com/apache/celeborn/pull/2300#discussion_r2513568026


##########
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/StorageManager.scala:
##########
@@ -107,21 +118,22 @@ final private[worker] class StorageManager(conf: CelebornConf, workerSource: Abs
   private val deviceMonitor =
     DeviceMonitor.createDeviceMonitor(conf, this, deviceInfos, tmpDiskInfos, workerSource)
 
-  private val byteBufAllocator: PooledByteBufAllocator =
+  val storageBufferAllocator: PooledByteBufAllocator =
     NettyUtils.getPooledByteBufAllocator(new TransportConf("StorageManager", conf), null, true)

Review Comment:
   community has workerSource passed into NettyUtils.getPooledByteBufAllocator
   
   do we need it, and how is it used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org