You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ace.apache.org by "Toni Menzel (JIRA)" <ji...@apache.org> on 2009/10/25 10:38:59 UTC
[jira] Created: (ACE-61) DeploymentServlet - Split different
purposes
DeploymentServlet - Split different purposes
--------------------------------------------
Key: ACE-61
URL: https://issues.apache.org/jira/browse/ACE-61
Project: Ace
Issue Type: Improvement
Reporter: Toni Menzel
DeploymentServlet acts as an endpoint for two very different services:
1. serve available versions for a given gateway
2. ship a particular version
It those different thing should not be handeled in one method as it makes things hard to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ACE-61) DeploymentServlet - Split different
purposes
Posted by "Toni Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Toni Menzel updated ACE-61:
---------------------------
Attachment: ACE-61.patch
Reorganized the class.
Actually this should be done for basically all servlets to ease (still to do) writing unit tests.
At best, servlet logic should be really held to a bare minimum because HttpServletRequest/Response are ugly to mock.
> DeploymentServlet - Split different purposes
> --------------------------------------------
>
> Key: ACE-61
> URL: https://issues.apache.org/jira/browse/ACE-61
> Project: Ace
> Issue Type: Improvement
> Reporter: Toni Menzel
> Attachments: ACE-61.patch
>
>
> DeploymentServlet acts as an endpoint for two very different services:
> 1. serve available versions for a given gateway
> 2. ship a particular version
> It those different thing should not be handeled in one method as it makes things hard to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ACE-61) DeploymentServlet - Split different
purposes
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans resolved ACE-61.
---------------------------------
Resolution: Fixed
Implemented the patches.
> DeploymentServlet - Split different purposes
> --------------------------------------------
>
> Key: ACE-61
> URL: https://issues.apache.org/jira/browse/ACE-61
> Project: Ace
> Issue Type: Improvement
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-61-newException.patch, ACE-61.patch
>
>
> DeploymentServlet acts as an endpoint for two very different services:
> 1. serve available versions for a given gateway
> 2. ship a particular version
> It those different thing should not be handeled in one method as it makes things hard to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ACE-61) DeploymentServlet - Split different
purposes
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans reassigned ACE-61:
-----------------------------------
Assignee: Marcel Offermans
> DeploymentServlet - Split different purposes
> --------------------------------------------
>
> Key: ACE-61
> URL: https://issues.apache.org/jira/browse/ACE-61
> Project: Ace
> Issue Type: Improvement
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Attachments: ACE-61-newException.patch, ACE-61.patch
>
>
> DeploymentServlet acts as an endpoint for two very different services:
> 1. serve available versions for a given gateway
> 2. ship a particular version
> It those different thing should not be handeled in one method as it makes things hard to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ACE-61) DeploymentServlet - Split different
purposes
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769780#action_12769780 ]
Marcel Offermans commented on ACE-61:
-------------------------------------
Agreed, it would be better to split this into multiple methods.
> DeploymentServlet - Split different purposes
> --------------------------------------------
>
> Key: ACE-61
> URL: https://issues.apache.org/jira/browse/ACE-61
> Project: Ace
> Issue Type: Improvement
> Reporter: Toni Menzel
>
> DeploymentServlet acts as an endpoint for two very different services:
> 1. serve available versions for a given gateway
> 2. ship a particular version
> It those different thing should not be handeled in one method as it makes things hard to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ACE-61) DeploymentServlet - Split different
purposes
Posted by "Toni Menzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACE-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Toni Menzel updated ACE-61:
---------------------------
Attachment: ACE-61-newException.patch
New exception (used in previous patch) to simplify error handling in rest servlets.
Once in a while, this exception should be (if finally accepted) staged up to a higher package. Will then probably be used by other ace rest servlets.
> DeploymentServlet - Split different purposes
> --------------------------------------------
>
> Key: ACE-61
> URL: https://issues.apache.org/jira/browse/ACE-61
> Project: Ace
> Issue Type: Improvement
> Reporter: Toni Menzel
> Attachments: ACE-61-newException.patch, ACE-61.patch
>
>
> DeploymentServlet acts as an endpoint for two very different services:
> 1. serve available versions for a given gateway
> 2. ship a particular version
> It those different thing should not be handeled in one method as it makes things hard to understand.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.