You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/27 01:58:49 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue #7022: Add test for gracefully shutdown
kezhenxu94 opened a new issue #7022:
URL: https://github.com/apache/skywalking/issues/7022
@kezhenxu94 I think with using `graceful shutting down`, we need a simple e2e to verify whether OAP and UI could be shut down successfully. Because, once we have one unexpected thread, the shutdown wouldn't work.
_Originally posted by @wu-sheng in https://github.com/apache/skywalking/pull/7020#discussion_r639758986_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7022: Add test for gracefully shutdown
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7022:
URL: https://github.com/apache/skywalking/issues/7022#issuecomment-849261062
> The simplest version is to update `JDK-version` CI process to add `shutdown` and `check` at the end of processes. @kezhenxu94 Make sense?
That makes sense of course.
For gracefully shutdown, you have to wait for a certain time to see whether or not the process has exited, the waiting duration is not predictable. I think the simplest method is to update the `docker-ci` case (which is simplest case for now), and execute the `shutdown.sh` after OAP is healthy, to see whether it's terminated.
The benefit is reducing the overall time of the entire workflows. `JDK-version` costs much more time than `docker-ci` already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #7022: Add test for gracefully shutdown
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7022:
URL: https://github.com/apache/skywalking/issues/7022#issuecomment-867283848
Closing as https://github.com/apache/skywalking/pull/7020#issuecomment-867280683 closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 closed issue #7022: Add test for gracefully shutdown
Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed issue #7022:
URL: https://github.com/apache/skywalking/issues/7022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org