[GitHub] [incubator-druid] Fokko commented on a change in pull request #8235: Use Closer instead of List

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #8235: Use Closer instead of List<Closeable>
URL: https://github.com/apache/incubator-druid/pull/8235#discussion_r310748843
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/common/io/Closer.java
 ##########
 @@ -123,6 +123,17 @@ private Closer()
     return closeable;
   }
 
+  /**
+   * Registers a list of  {@code closeable} to be closed when this {@code Closer} is
+   * {@linkplain #close closed}.
+   */
+  // close. this word no longer has any meaning to me.
 
 Review comment:
   This is copy-paste. It is already in current master :-)
   
   https://github.com/apache/incubator-druid/blob/master/core/src/main/java/org/apache/druid/java/util/common/io/Closer.java#L116
   
   I'll remove it anyway 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org