You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/05/18 22:33:55 UTC
[GitHub] [samza] prateekm commented on a change in pull request #1363: AzureBlobSystemProducer: Catch all throwable in completableFuture during flush of producer
prateekm commented on a change in pull request #1363:
URL: https://github.com/apache/samza/pull/1363#discussion_r426928216
##########
File path: samza-azure/src/main/java/org/apache/samza/system/azureblob/producer/AzureBlobSystemProducer.java
##########
@@ -490,7 +490,7 @@ private void closeWriters(String source, Map<String, AzureBlobWriter> sourceWrit
public void run() {
try {
writer.close();
- } catch (IOException e) {
+ } catch (Throwable e) {
Review comment:
Minor: Should catch Exception instead of Throwable. Later includes fatal errors like OOM, stack overflow, classloading errors etc that typically shouldn't be caught.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org