[GitHub] [samza] shanthoosh commented on a change in pull request #1016: SAMZA-2179: Move the StartpointVisitor abstraction to SystemAdmin interface.

[GitBox <gi...@apache.org>]

shanthoosh commented on a change in pull request #1016: SAMZA-2179: Move the StartpointVisitor abstraction to SystemAdmin interface.
URL: https://github.com/apache/samza/pull/1016#discussion_r279904755
 
 

 ##########
 File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
 ##########
 @@ -309,11 +314,11 @@ public String toString() {
     return super.poll(systemStreamPartitions, timeout);
   }
 
-  static TopicAndPartition toTopicAndPartition(TopicPartition tp) {
+  public static TopicAndPartition toTopicAndPartition(TopicPartition tp) {
 
 Review comment:
   This static method is used internally in LinkedIn for KafkaConsumer adaptations to get large-message support and in beam. Currently, in all the internal classes, this particular code has been copy-pasted.  Moreover, this does not expose any internal state of KafkaConsumer and is a pure static function. We could remove duplication internally at LI at-least if this is public.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services