[GitHub] [pulsar] gaozhangmin commented on a diff in pull request #14756: [metrics] Metrics http interface unified authentication configuration

[GitBox <gi...@apache.org>]

gaozhangmin commented on code in PR #14756:
URL: https://github.com/apache/pulsar/pull/14756#discussion_r849026358


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2288,6 +2288,12 @@ public class ServiceConfiguration implements PulsarConfiguration {
     private int webSocketMaxTextFrameSize = 1048576;
 
     /**** --- Metrics. --- ****/
+    @FieldContext(
+            category = CATEGORY_METRICS,
+            doc = "Whether the '/metrics' endpoint requires authentication. Defaults to false."
+                    + "'authenticationEnabled' must also be set for this to take effect."
+    )
+    private boolean authenticateMetricsEndpoint = false;

Review Comment:
   @liudezhi2098  We may miss the configuration `authenticateMetricsEndpoint` in proxy.conf.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org