You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "Prasad Kashyap (JIRA)" <ji...@apache.org> on 2006/12/05 05:23:20 UTC
[jira] Created: (OPENEJB-397) Fix DummyTest.java in itests.
Fix DummyTest.java in itests.
------------------------------
Key: OPENEJB-397
URL: http://issues.apache.org/jira/browse/OPENEJB-397
Project: OpenEJB
Issue Type: Bug
Components: integration
Reporter: Prasad Kashyap
setup() and teardown() still continue to miss the test name.
We'll have to go back to the DummyTest.java that was first used in the patch in OpenEJB-301.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OPENEJB-397) Fix DummyTest.java in itests.
Posted by "David Blevins (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-397?page=all ]
David Blevins closed OPENEJB-397.
---------------------------------
Resolution: Fixed
Assignee: David Blevins
All fixed. I applied a slightly different fix:
--- incubator/openejb/trunk/openejb2/itests/openejb-itests-core/src/test/java/org/apache/openejb/test/NumberedTestCase.java (original)
+++ incubator/openejb/trunk/openejb2/itests/openejb-itests-core/src/test/java/org/apache/openejb/test/NumberedTestCase.java Tue Dec 5 14:33:54 2006
@@ -93,7 +93,7 @@
try {
setUp();
} catch (Exception e) {
- result.addError(new DummyTest(".setUp()", 0), e);
+ result.addError(new DummyTest(createTestName("setUp"), 0), e);
return;
}
for (int i = 0; i < testMethods.length; i++) {
@@ -102,7 +102,7 @@
try {
tearDown();
} catch (Exception e) {
- result.addError(new DummyTest(".tearDown()", 0), e);
+ result.addError(new DummyTest(createTestName("tearDown"), 0), e);
return;
}
}
@@ -150,7 +150,11 @@
}
protected String createTestName(Method testMethod) {
- return name() + removePrefix(testMethod.getName());
+ return createTestName(testMethod.getName());
+ }
+
+ private String createTestName(String methodName) {
+ return name() + removePrefix(methodName);
}
> Fix DummyTest.java in itests.
> -----------------------------
>
> Key: OPENEJB-397
> URL: http://issues.apache.org/jira/browse/OPENEJB-397
> Project: OpenEJB
> Issue Type: Bug
> Components: integration
> Reporter: Prasad Kashyap
> Assigned To: David Blevins
> Attachments: DummyTestFix.patch
>
>
> setup() and teardown() still continue to miss the test name.
> We'll have to go back to the DummyTest.java that was first used in the patch in OpenEJB-301.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OPENEJB-397) Fix DummyTest.java in itests.
Posted by "Prasad Kashyap (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OPENEJB-397?page=all ]
Prasad Kashyap updated OPENEJB-397:
-----------------------------------
Attachment: DummyTestFix.patch
> Fix DummyTest.java in itests.
> -----------------------------
>
> Key: OPENEJB-397
> URL: http://issues.apache.org/jira/browse/OPENEJB-397
> Project: OpenEJB
> Issue Type: Bug
> Components: integration
> Reporter: Prasad Kashyap
> Attachments: DummyTestFix.patch
>
>
> setup() and teardown() still continue to miss the test name.
> We'll have to go back to the DummyTest.java that was first used in the patch in OpenEJB-301.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira