[GitHub] kalium99 commented on a change in pull request #3346: Updated installation documentation to include MySql devlopment libraries

[GitBox <gi...@apache.org>]

kalium99 commented on a change in pull request #3346: Updated installation documentation to include MySql devlopment libraries
URL: https://github.com/apache/incubator-superset/pull/3346#discussion_r211821041
 
 

 ##########
 File path: docs/installation.rst
 ##########
 @@ -26,12 +26,14 @@ For **Debian** and **Ubuntu**, the following command will ensure that
 the required dependencies are installed: ::
 
     sudo apt-get install build-essential libssl-dev libffi-dev python-dev python-pip libsasl2-dev libldap2-dev
+    sudo apt-get install libmysqlclient-dev
 
 For **Fedora** and **RHEL-derivatives**, the following command will ensure
 that the required dependencies are installed: ::
 
     sudo yum upgrade python-setuptools
     sudo yum install gcc gcc-c++ libffi-devel python-devel python-pip python-wheel openssl-devel libsasl2-devel openldap-devel
+    sudo yum install mysql-devel
 
 Review comment:
   The `mysqlclient` Python package is not optional when running tests (i.e running `tox -e <py_version>`). So AFAICT this will break for everyone who wants to run the tests (which it did for me) if they don't have the `mysql_config` script.
   
   However, this patch is not the right place for this as this `docs/installation.rst` is for the actual installation. I know little about Tox, but I can't see where there is a natural place where OS deps are handled (which is not surprising). Having a Tox plugin for handling this would be nice. Wrapping the whole thing in a script like `./run-tests -e <py_env>` where the OS deps can be handled might be an option ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org