You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/24 11:29:23 UTC
[GitHub] [spark] zhengruifeng commented on issue #26232:
[SPARK-29093][PYTHON][ML] Remove automatically generated param setters in
_shared_params_code_gen.py
zhengruifeng commented on issue #26232: [SPARK-29093][PYTHON][ML] Remove automatically generated param setters in _shared_params_code_gen.py
URL: https://github.com/apache/spark/pull/26232#issuecomment-545875076
1, why you remove the `__metaclass__ = ABCMeta` in wrapper.py?
2, can we add the missing since annotations for new added setters?
I can not 'add single comment' or 'start a review', I guess that is beacuse this PR is still to large although we had finished some preposed PRs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org