You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2012/12/14 00:12:12 UTC
[jira] [Commented] (LUCENE-4629) IndexWriter fails to delete
documents if Iterator throws an exception
[ https://issues.apache.org/jira/browse/LUCENE-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531618#comment-13531618 ]
Michael McCandless commented on LUCENE-4629:
--------------------------------------------
Nice catch! Sneaky.
+1 to remove entire block if anything goes wrong, and +1 for patch.
Thanks Simon.
> IndexWriter fails to delete documents if Iterator<IndexDocument> throws an exception
> ------------------------------------------------------------------------------------
>
> Key: LUCENE-4629
> URL: https://issues.apache.org/jira/browse/LUCENE-4629
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4629.patch
>
>
> In DWPT we iterator over a document block and roll back documents if one of the docs fails with a non-aborting exception. Yet, we miss to delete those document if the iterator itself throws an exception. Given the fact that we allow an Iterable on IW we should be prepared for RT exceptions since these documents might be created in a stream fashing rather than already build up. IMO its a valid usecase if you have large documents to not materialize them in memory before indexing or at least we don't require this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org