[GitHub] [airflow] dstandish commented on a change in pull request #19339: Touch up k8s executor doc

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #19339:
URL: https://github.com/apache/airflow/pull/19339#discussion_r740365570



##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -46,26 +46,26 @@ This command generates the pods as they will be launched in Kubernetes and dumps
 pod_template_file
 #################
 
-As of Airflow 1.10.12, you can now use the ``pod_template_file`` option in the ``kubernetes`` section
+As of Airflow 1.10.12, you can use the ``pod_template_file`` option in the ``kubernetes`` section

Review comment:
       I think the intention of this sentence is to say when the feature was added, so if we want to leave it structured like this I think it makes sense to leave 1.10.12.  However, at a certain point, it doesn't matter when the feature was added.  So we _could_ just remove that reference and get to the point --- "To customize the pod used for k8s executor worker processes, _use_ `pod_template_file`..." or similar.  WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org