You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/14 12:49:55 UTC
[GitHub] [beam] piotr-szuberski opened a new pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
piotr-szuberski opened a new pull request #13542:
URL: https://github.com/apache/beam/pull/13542
Hopefully this will help with these tests being flaky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on a change in pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on a change in pull request #13542:
URL: https://github.com/apache/beam/pull/13542#discussion_r544186235
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -177,16 +177,6 @@ task runPojoExample(type: JavaExec) {
args = ["--runner=DirectRunner"]
}
-// These tests become flaky when run in parallel at more than 3 threads so run them in a separate task
-task runKafkaTableProviderIT(type: Test) {
- outputs.upToDateWhen { false }
- include '**/KafkaTableProvider*IT.class'
- maxParallelForks 2
- classpath = project(":sdks:java:extensions:sql").sourceSets.test.runtimeClasspath
- testClassesDirs = files(project(":sdks:java:extensions:sql").sourceSets.test.output.classesDirs)
- useJUnit { }
-}
-
Review comment:
I'll replace the inheritance with parameterized tests, there shouldn't be need for a separate Kafka task. The same problem was with Pubsub IT tests so the task would have to receive GCP credentials as well to be able to run these as well.
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -177,16 +177,6 @@ task runPojoExample(type: JavaExec) {
args = ["--runner=DirectRunner"]
}
-// These tests become flaky when run in parallel at more than 3 threads so run them in a separate task
-task runKafkaTableProviderIT(type: Test) {
- outputs.upToDateWhen { false }
- include '**/KafkaTableProvider*IT.class'
- maxParallelForks 2
- classpath = project(":sdks:java:extensions:sql").sourceSets.test.runtimeClasspath
- testClassesDirs = files(project(":sdks:java:extensions:sql").sourceSets.test.output.classesDirs)
- useJUnit { }
-}
-
Review comment:
I'll replace the inheritance with parameterized tests, then there shouldn't be need for a separate Kafka task. The same problem was with Pubsub IT tests so the task would have to receive GCP credentials as well to be able to run these as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a change in pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on a change in pull request #13542:
URL: https://github.com/apache/beam/pull/13542#discussion_r543421287
##########
File path: sdks/java/extensions/sql/build.gradle
##########
@@ -177,16 +177,6 @@ task runPojoExample(type: JavaExec) {
args = ["--runner=DirectRunner"]
}
-// These tests become flaky when run in parallel at more than 3 threads so run them in a separate task
-task runKafkaTableProviderIT(type: Test) {
- outputs.upToDateWhen { false }
- include '**/KafkaTableProvider*IT.class'
- maxParallelForks 2
- classpath = project(":sdks:java:extensions:sql").sourceSets.test.runtimeClasspath
- testClassesDirs = files(project(":sdks:java:extensions:sql").sourceSets.test.output.classesDirs)
- useJUnit { }
-}
-
Review comment:
Can we keep the Kafka test in a separate non-parallel task so the other ITs can still run in parallel?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746106312
@TheNeuralBit Thanks for motivating me to do something better than reducing the thread amount.
I've got rid of inheritance and replaced it with parameterized tests and added some SuppressWarnings to make the code look cleaner in IntelliJ.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746054371
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski edited a comment on pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski edited a comment on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746106312
@TheNeuralBit Thanks for motivating me to do something better than reducing the thread amount!
I've got rid of inheritance, replaced it with parameterized tests and added some SuppressWarnings to make the code look cleaner in IntelliJ.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged pull request #13542:
URL: https://github.com/apache/beam/pull/13542
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745137845
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-744442804
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski edited a comment on pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski edited a comment on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746106312
@TheNeuralBit Thanks for motivating me to do something better than reducing the thread amount!
I've got rid of inheritance, replaced it with parameterized tests and added some SuppressWarnings to make the code look cleaner in IntelliJ. Now each of the test classes run sequentially
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski edited a comment on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski edited a comment on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746106312
@TheNeuralBit Thanks for motivating me to do something better than reducing the thread amount.
I've got rid of inheritance, replaced it with parameterized tests and added some SuppressWarnings to make the code look cleaner in IntelliJ.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745138499
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-749666283
Sorry lost track of this! Taking a look now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski removed a comment on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski removed a comment on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745137845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-749589308
> Is it ready to be merged? I see that it was already approved.
Nope, there was an approval but I wanted to follow up the suggestion to do it in a better way and refactored the code so the tests now are parameterized and run sequentially. So it's waiting for review atm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski edited a comment on pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski edited a comment on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746106312
@TheNeuralBit Thanks for motivating me to do something better than reducing the thread amount!
I've got rid of inheritance, replaced it with parameterized tests and added some SuppressWarnings to make the code look cleaner in IntelliJ. Now each of the test classes run sequentially. It looks like the inheritance was not too good idea in this case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745210845
R: @TheNeuralBit Could I ask you to review this small PR? You're the closest one to this part of code.
Kafka IT tests became flaky when they were running in parallel. It seems that setting 2 threads reduced the flakiness but only partially. Maybe when the tests are run on single thread they will stop being flaky. I also increased the timeout times, just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745198398
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745208953
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746073358
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745125056
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on pull request #13542: [BEAM-11456] Fix flaky table provider IT tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-749569099
Is it ready to be merged? I see that it was already approved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-744418087
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-745135379
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] piotr-szuberski commented on pull request #13542: [BEAM-11456] Fix flaky table provider tests (Kafka and Pubsub)
Posted by GitBox <gi...@apache.org>.
piotr-szuberski commented on pull request #13542:
URL: https://github.com/apache/beam/pull/13542#issuecomment-746136353
Run SQL PostCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org