You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/24 02:46:03 UTC
[GitHub] [incubator-nuttx] Donny9 opened a new pull request, #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS
Donny9 opened a new pull request, #7404:
URL: https://github.com/apache/incubator-nuttx/pull/7404
## Summary
The default size of file cache is size of a sector, it may not be good size for optimizing read speed in physical device. So we can set the config according to speed test profile to optimize access IO speed.
Signed-off-by: dongjiuzhu1 <do...@xiaomi.com>
## Impact
improve read speed for romfs
## Testing
Vela CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7404:
URL: https://github.com/apache/incubator-nuttx/pull/7404#discussion_r1002937958
##########
fs/romfs/Kconfig:
##########
@@ -20,4 +20,10 @@ config FS_ROMFS_CACHE_NODE
is mounted so that we can quick access entry of ROMFS
filesystem on emmc/sdcard.
+config FS_ROMFS_CACHE_FILE_NSECTORS
+ int "The number of file cache sector"
+ default 1
Review Comment:
do we need to add range check here so 0 can't be set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS
Posted by GitBox <gi...@apache.org>.
Donny9 commented on code in PR #7404:
URL: https://github.com/apache/incubator-nuttx/pull/7404#discussion_r1003024391
##########
fs/romfs/Kconfig:
##########
@@ -20,4 +20,10 @@ config FS_ROMFS_CACHE_NODE
is mounted so that we can quick access entry of ROMFS
filesystem on emmc/sdcard.
+config FS_ROMFS_CACHE_FILE_NSECTORS
+ int "The number of file cache sector"
+ default 1
Review Comment:
Done. set range to 1-256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7404:
URL: https://github.com/apache/incubator-nuttx/pull/7404#issuecomment-1288984795
let ignore the ci broken, which is fixed in:
https://github.com/apache/incubator-nuttx/pull/7409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7404: romfs: expand file cache by CONFIG_FS_ROMFS_FCACHE_NSECTORS
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7404:
URL: https://github.com/apache/incubator-nuttx/pull/7404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org