You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by matthiasblaesing <gi...@git.apache.org> on 2017/09/29 21:04:07 UTC

[GitHub] incubator-netbeans pull request #24: [NETBEANS-54] Module Review db.sql.visu...

GitHub user matthiasblaesing opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/24

    [NETBEANS-54] Module Review db.sql.visualeditor

    - external library javacc is only used at build time and is not
      distributed with netbeans
    
    - modified binaries-list to point to maven coordinates
    
    - checked Rat report; missing headers added, ignored *.form 
      (see central problems)
    
    - skimmed through the module, did not notice additional problems

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/matthiasblaesing/incubator-netbeans db.sql.visualeditor-review

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 6e470a8ef57af875989dac5a02e125536c203f34
Author: Matthias Bläsing <mb...@doppel-helix.eu>
Date:   2017-09-29T20:57:42Z

    [NETBEANS-54] Module Review db.sql.visualeditor
    
    - external library javacc is only used at build time and is not
      distributed with netbeans
    
    - modified binaries-list to point to maven coordinates
    
    - checked Rat report; missing headers added, ignored *.form 
      (see central problems)
    
    - skimmed through the module, did not notice additional problems

----


---

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

Posted by emilianbold <gi...@git.apache.org>.

Github user emilianbold commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/24
  
    binaries-list is a "problem to be solved centrally". I would not add license headers to it.


---

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/24
  
    When that central decision is made, there is already at least one file that has this change already `db/external/binaries-list`. In any case the header is not wrong. The file is part of an apache project and was thus donated by oracle and is now covered by the apache license. If there is a consensus, that the license header is not needed, than it can still be left in place or at that time centrally removed. Till then I consider each file I don't have to discuss about a good file.


---

[GitHub] incubator-netbeans pull request #24: [NETBEANS-54] Module Review db.sql.visu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/24


---

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

Posted by emilianbold <gi...@git.apache.org>.

Github user emilianbold commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/24
  
    ... unless the central decision will be not to use headers and then your file becomes the only one that has to be manually tweaked back.


---

[GitHub] incubator-netbeans issue #24: [NETBEANS-54] Module Review db.sql.visualedito...

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/24
  
    I had to touch binaries-list to change it to maven coordinates - so adding the license header was a natural reaction. From my POV there is no gain by removing that header again - do you agree?


---