[GitHub] [kafka] prince-mahajan commented on a change in pull request #11742: KAFKA-13636: Fix for the group coordinator issue where the offsets are deleted for unstable groups

[GitBox <gi...@apache.org>]

prince-mahajan commented on a change in pull request #11742:
URL: https://github.com/apache/kafka/pull/11742#discussion_r803107096



##########
File path: core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala
##########
@@ -763,7 +763,7 @@ private[group] class GroupMetadata(val groupId: String, initialState: GroupState
     }
 
     val expiredOffsets: Map[TopicPartition, OffsetAndMetadata] = protocolType match {
-      case Some(_) if is(Empty) =>
+      case Some(_) if is(Empty) || !is(Stable)=>

Review comment:
       Yes, I was saying that we can expire offsets with the larger expiration time (per KIP-211):  if currentStateTimestamp has elapsed. But, you are right, it is better to not expire at all when in this state. I assume the group will eventually transition to either Stable or Empty state and we can expire then.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org