You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "mbeckerle (via GitHub)" <gi...@apache.org> on 2023/06/23 16:18:57 UTC

[GitHub] [daffodil-vscode] mbeckerle commented on a diff in pull request #677: Launch Wizard updates based on 1.3.0-rc3 issues

mbeckerle commented on code in PR #677:
URL: https://github.com/apache/daffodil-vscode/pull/677#discussion_r1240005281


##########
package.json:
##########
@@ -345,7 +344,7 @@
                 "type": "object",
                 "description": "Destination for final Infoset ('file' | 'console' | 'none')",
                 "default": {
-                  "type": "console",
+                  "type": "file",
                   "path": "${workspaceFolder}/infoset.xml"

Review Comment:
   The default location for this shoudl be "${workspaceFolder}/target/infoset.xml" so that it doesn't clutter and end up committed by accident. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org