[GitHub] [flink] TsReaper opened a new pull request #9098: [FLINK-13236][table-runtime-blink] Fix bug and improve performance in TopNBuffer

[GitBox <gi...@apache.org>]

TsReaper opened a new pull request #9098: [FLINK-13236][table-runtime-blink] Fix bug and improve performance in TopNBuffer
URL: https://github.com/apache/flink/pull/9098
 
 
   ## What is the purpose of the change
   
   The value of `currentTopNum` will be incorrectly calculated in the `putAll` method of `TopNBuffer` when the given `sortKey` exists in `treeMap`.
   
   Also, the inner loop of `getElement` method can be removed to improve performance.
   
   ## Brief change log
   
    - Fix `putAll` method in `TopNBuffer`
    - Improve performance of `getElement` method in `TopNBuffer`
   
   ## Verifying this change
   
   This change is a trivial bug fix / improvement without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services