You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/27 22:09:18 UTC

[GitHub] [spark] rdblue opened a new pull request #24723: [SPARK-27857] Move ALTER TABLE parsing into Catalyst

rdblue opened a new pull request #24723: [SPARK-27857] Move ALTER TABLE parsing into Catalyst
URL: https://github.com/apache/spark/pull/24723
 
 
   ## What changes were proposed in this pull request?
   
   This moves parsing logic for `ALTER TABLE` into Catalyst and adds parsed logical plans for alter table changes that use multi-part identifiers. This PR is similar to SPARK-27108, PR #24029, that created parsed logical plans for create and CTAS.
   
   * Create parsed logical plans
   * Move parsing logic into Catalyst's AstBuilder
   * Convert to DataSource plans in DataSourceResolution
   * Parse `ALTER TABLE ... SET LOCATION ...` separately from the partition variant
   * Parse `ALTER TABLE ... ALTER COLUMN ... [TYPE dataType] [COMMENT comment]` as discussed on the dev list
   * Parse `ALTER TABLE ... RENAME COLUMN ... TO ...`
   * Parse `ALTER TABLE ... DROP COLUMNS ...`
   
   ## How was this patch tested?
   
   * Added new tests in Catalyst's `DDLParserSuite`
   * Moved converted plan tests from SQL `DDLParserSuite` to `PlanResolutionSuite`
   * Existing tests for regressions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org