You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "shanedell (via GitHub)" <gi...@apache.org> on 2023/11/09 21:58:11 UTC
[PR] Update NONOTICE and NOTICE [daffodil-vscode]
shanedell opened a new pull request, #896:
URL: https://github.com/apache/daffodil-vscode/pull/896
Update NONOTICE and NOTICE
- Add missing dependcies to NOTICE and NOTICE files.
- Clean up the NOTICE information for Apache Pekko:
- Everything used to be a single repo but seems they split into multiple now.
- Fix version in package.json to go back to a SNAPSHOT version.
Closes #839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update NONOTICE and NOTICE [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell merged PR #896:
URL: https://github.com/apache/daffodil-vscode/pull/896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update NONOTICE and NOTICE [daffodil-vscode]
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on code in PR #896:
URL: https://github.com/apache/daffodil-vscode/pull/896#discussion_r1388631499
##########
package.json:
##########
@@ -2,7 +2,7 @@
"name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil™ Extension for Visual Studio Code",
"description": "Apache Daffodil™ Extension for Visual Studio Code providing DFDL syntax highlighting, DFDL code completion, DFDL schema debugging, and data editor",
- "version": "1.3.1",
+ "version": "1.4.0-SNAPSHOT",
Review Comment:
This is interesting, and I agree with this change. After we do a release, we should probably do this as the next merged commit, until the next release and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update NONOTICE and NOTICE [daffodil-vscode]
Posted by "shanedell (via GitHub)" <gi...@apache.org>.
shanedell commented on PR #896:
URL: https://github.com/apache/daffodil-vscode/pull/896#issuecomment-1832553100
@mbeckerle @stevedlawrence @arosien @stricklandrbls @rthomas320 Would one of you mind giving this a review/approval?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org