You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/09/23 07:00:27 UTC
[GitHub] [jackrabbit] rkovarik commented on a diff in pull request #128: JCR-4608 Upgrade to commons-collections4
rkovarik commented on code in PR #128:
URL: https://github.com/apache/jackrabbit/pull/128#discussion_r978318905
##########
jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java:
##########
@@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {
return n;
}
+ @Override
public void remove() {
throw new UnsupportedOperationException("remove");
}
-
Review Comment:
I've added test for concurrent modification. Was passing when I accessed the modCount field via reflection but doesn't work when I overlay the field. Must be a stupid mistake but I can't see it 🤔
##########
jackrabbit-jcr2spi/src/main/java/org/apache/jackrabbit/jcr2spi/hierarchy/ChildNodeEntriesImpl.java:
##########
@@ -704,15 +701,10 @@ public LinkedEntries.LinkNode next() {
return n;
}
+ @Override
public void remove() {
throw new UnsupportedOperationException("remove");
}
-
Review Comment:
I've added a test for concurrent modification. Was passing when I accessed the modCount field via reflection but doesn't work when I overlay the field. Must be a stupid mistake but I can't see it 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org