You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/13 07:38:35 UTC

[GitHub] [flink] aljoscha commented on a change in pull request #13583: [FLINK-19154] ApplicationDispatcherBootstrap clean up HA data only when necessary.

aljoscha commented on a change in pull request #13583:
URL: https://github.com/apache/flink/pull/13583#discussion_r503731517



##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherGatewayServiceFactory.java
##########
@@ -92,6 +91,7 @@ public ApplicationDispatcherGatewayServiceFactory(
 			throw new FlinkRuntimeException("Could not create the Dispatcher rpc endpoint.", e);
 		}
 
+		bootstrap.setErrorHandler(exception -> dispatcher.getShutDownFuture().completeExceptionally(exception));

Review comment:
       You can't pass it in the constructor because of the chicken-and-egg problem, right? You need the bootstrap to create the dispatcher but you need the dispatcher to create the `FatalErrorHandler`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org