You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Michael Park <mc...@gmail.com> on 2014/12/19 03:48:07 UTC

Review Request 29233: Add instruction for ClangFormat installation and editor integration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29233/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Dominic Hamon.


Bugs: MESOS-1291
    https://issues.apache.org/jira/browse/MESOS-1291


Repository: mesos-git


Description
-------

Add instruction for ClangFormat installation and editor integration.


Diffs
-----

  docs/clang-format.md PRE-CREATION 

Diff: https://reviews.apache.org/r/29233/diff/


Testing
-------


Thanks,

Michael Park


Re: Review Request 29233: Add instruction for ClangFormat installation and editor integration.

Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29233/#review67431
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rukletsov


On Dec. 23, 2014, 9:14 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29233/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1291
>     https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add instruction for ClangFormat installation and editor integration.
> 
> 
> Diffs
> -----
> 
>   docs/clang-format.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 29233: Add instruction for ClangFormat installation and editor integration.

Posted by Till Toenshoff <to...@me.com>.

> On Jan. 9, 2015, 12:48 p.m., Till Toenshoff wrote:
> > Ship It!

This is great, thanks MPark!


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29233/#review67426
-----------------------------------------------------------


On Dec. 23, 2014, 9:14 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29233/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1291
>     https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add instruction for ClangFormat installation and editor integration.
> 
> 
> Diffs
> -----
> 
>   docs/clang-format.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 29233: Add instruction for ClangFormat installation and editor integration.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29233/#review67426
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Dec. 23, 2014, 9:14 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29233/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 9:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.
> 
> 
> Bugs: MESOS-1291
>     https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add instruction for ClangFormat installation and editor integration.
> 
> 
> Diffs
> -----
> 
>   docs/clang-format.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Re: Review Request 29233: Add instruction for ClangFormat installation and editor integration.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29233/
-----------------------------------------------------------

(Updated Dec. 23, 2014, 9:14 p.m.)


Review request for mesos, Benjamin Hindman, Dominic Hamon, and Till Toenshoff.


Bugs: MESOS-1291
    https://issues.apache.org/jira/browse/MESOS-1291


Repository: mesos-git


Description
-------

Add instruction for ClangFormat installation and editor integration.


Diffs
-----

  docs/clang-format.md PRE-CREATION 

Diff: https://reviews.apache.org/r/29233/diff/


Testing
-------


Thanks,

Michael Park


Re: Review Request 29233: Add instruction for ClangFormat installation and editor integration.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29233/#review65594
-----------------------------------------------------------


Patch looks great!

Reviews applied: [29233]

All tests passed.

- Mesos ReviewBot


On Dec. 19, 2014, 2:48 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29233/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2014, 2:48 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-1291
>     https://issues.apache.org/jira/browse/MESOS-1291
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Add instruction for ClangFormat installation and editor integration.
> 
> 
> Diffs
> -----
> 
>   docs/clang-format.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/29233/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>