[jira] [Commented] (TC-175) Traffic Monitor 2.0 doesn't remove OFFLINEd peers

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TC-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898113#comment-15898113 ] 

ASF GitHub Bot commented on TC-175:
-----------------------------------

GitHub user rob05c opened a pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/332

    Fix TM2 to remove OFFLINEd peers, timeout peers

    Fixes Traffic Monitor 2.0 to remove peers which have been marked
    OFFLINE in Traffic Ops from its endpoints. OFFLINEd peers are removed
    from `PeerStates`, and their availability is removed from `CrStates`.
    
    Fixes to timeout peers which don't respond. Peers which haven't
    responded in (pollInterval+httpTimeout)*2 are removed from CrStates.
    
    Fixes TC-175

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rob05c/incubator-trafficcontrol tm2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafficcontrol/pull/332.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #332
    
----

----


> Traffic Monitor 2.0 doesn't remove OFFLINEd peers
> -------------------------------------------------
>
>                 Key: TC-175
>                 URL: https://issues.apache.org/jira/browse/TC-175
>             Project: Traffic Control
>          Issue Type: Bug
>          Components: Traffic Monitor (golang)
>    Affects Versions: 2.0.0
>         Environment: Any
>            Reporter: Robert Butts
>            Priority: Critical
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> If a Traffic Monitor is ONLINE in Traffic Ops, and thus in the peers data of other Traffic Monitors, and then changed to OFFLINE, other Golang Traffic Monitors stop polling, but continue to mark that peer as available, thus 'freezing' the availability of all their caches.
> Because peer statuses are optimistic, all caches which were marked 'available' by that OFFLINEd monitor are then permanently available in all other monitors' `/publish/CrStates`.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)