You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/05 12:38:11 UTC
[GitHub] [incubator-superset] oashton opened a new pull request #9210: Add maximize and minimize feature to charts
oashton opened a new pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210
### CATEGORY
Choose one
- [ ] Bug Fix
- [X] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Add a new option in the chart contextual menu:
* The label change between Maximize and Minimize depending of the chart state
* The maximize chart take all the available space in the browser
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
Click in the three dots menu in any chart, click the Maximize option.
Click again in the three dots menu in any chart, click the Minimize option.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #9209
- [X] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.21%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21500 +12643
- Misses 3593 8793 +5200
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.58% <52.63%> (-0.01%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `87.09% <25.00%> (-2.80%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `73.33% <0.00%> (ø)` | |
| [superset/utils/feature\_flag\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZmVhdHVyZV9mbGFnX21hbmFnZXIucHk=) | `93.75% <0.00%> (ø)` | |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `88.67% <0.00%> (ø)` | |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `80.35% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/cockroachdb.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NvY2tyb2FjaGRiLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.89% <0.00%> (ø)` | |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-623650468
@villebro , a test commited a couple of hours ago is breaking the checks... where can I report it?
Correction: 4 days ago
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-623650468
@villebro , a test commited a couple of hours ago is breaking the checks... where can I report it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624124195
Thanks for the patience @oashton ; it seems CI threw some very unrelated error. I restarted it just in case, but if that doesn't work out we might be better off just reopening a new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-650265470
Thanks again @oashton for this, really cool feature! ❤️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624179662
> Oh, it seems the test problem was already fixed. Would you mind rebasing one more time @oashton ?
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-620963242
@oashton I wonder if something went wrong in the rebase? This is showing 520 files changed with `+66,552 −33,417` rows changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.20%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21499 +12642
- Misses 3593 8794 +5201
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/examples/sf\_population\_polygons.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvc2ZfcG9wdWxhdGlvbl9wb2x5Z29ucy5weQ==) | `29.16% <0.00%> (ø)` | |
| [superset/charts/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2RlbGV0ZS5weQ==) | `90.90% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `85.71% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `93.02% <0.00%> (ø)` | |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `89.71% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-650280261
Stoked that this is in! Thanks @oashton!
Paging @Steejay - maybe we can find a home for a slick maximize/minimize toggle button somewhere in the redesign project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.20%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21499 +12642
- Misses 3593 8794 +5201
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/common/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3RhZ3MucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `90.90% <0.00%> (ø)` | |
| [superset/sql\_validators/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvYmFzZS5weQ==) | `100.00% <0.00%> (ø)` | |
| [superset/views/chart/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvbWl4aW4ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624188940
@etr2460 as you've reviewed this more in-depth, would you mind taking a look and merging if all is well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.21%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.70% +0.21%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21500 +12643
- Misses 3593 8793 +5200
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.58% <52.63%> (-0.01%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.87% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `87.09% <25.00%> (-2.80%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | `97.50% <0.00%> (ø)` | |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `77.77% <0.00%> (ø)` | |
| [superset/common/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3RhZ3MucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | `85.71% <0.00%> (ø)` | |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.56% <0.00%> (ø)` | |
| [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `95.45% <0.00%> (ø)` | |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-620015107
@oashton can you rebase this? We've moved off Travis due to problems with PRs getting stuck (this one is also stuck hence can't be merged), and rebasing might fix the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.57% +0.08%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21460 +12603
- Misses 3593 8833 +5240
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.65% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/dashboards/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9kYW8ucHk=) | `91.48% <0.00%> (ø)` | |
| [superset/sql\_validators/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvX19pbml0X18ucHk=) | `80.00% <0.00%> (ø)` | |
| [superset/examples/random\_time\_series.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvcmFuZG9tX3RpbWVfc2VyaWVzLnB5) | `22.58% <0.00%> (ø)` | |
| [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `96.29% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624179662
> Oh, it seems the test problem was already fixed. Would you mind rebasing one more time @oashton ?
Done @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-635465579
> @etr2460 as you've reviewed this more in-depth, would you mind taking a look and merging if all is well?
@etr2460 , is there anything left to do?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
- Coverage 70.49% 70.46% -0.04%
==========================================
Files 402 402
Lines 12564 12583 +19
Branches 3112 3116 +4
==========================================
+ Hits 8857 8866 +9
- Misses 3593 3603 +10
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **decrease** coverage by `11.61%`.
> The diff coverage is `42.10%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
===========================================
- Coverage 70.49% 58.88% -11.62%
===========================================
Files 402 402
Lines 12564 12583 +19
Branches 3112 3116 +4
===========================================
- Hits 8857 7409 -1448
- Misses 3593 4990 +1397
- Partials 114 184 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `24.00% <ø> (-32.00%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `10.63% <0.00%> (-56.81%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `65.59% <25.00%> (-24.30%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `77.14% <63.63%> (-4.22%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [139 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624049565
> > @oashton I wonder if something went wrong in the rebase? This is showing 520 files changed with `+66,552 −33,417` rows changed.
>
> @villebro , yes... I'm gonna fix it... I'll let you know as soon as a finish
@villebro ... fixed. Let me know if there is anything else to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624125535
Oh, it seems the test problem was already fixed. Would you mind rebasing one more time @oashton ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-620897549
> @oashton can you rebase this? We've moved off Travis due to problems with PRs getting stuck (this one is also stuck hence can't be merged), and rebasing might fix the problem.
@villebro Done. Let me know if there is anything else to do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-593630756
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=h1) Report
> Merging [#9210](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9210 +/- ##
==========================================
+ Coverage 70.49% 70.57% +0.08%
==========================================
Files 402 584 +182
Lines 12564 30407 +17843
Branches 3112 3116 +4
==========================================
+ Hits 8857 21460 +12603
- Misses 3593 8833 +5240
Partials 114 114
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.56% <52.63%> (-0.02%)` | :arrow_down: |
| #javascript | `58.88% <42.10%> (-0.03%)` | :arrow_down: |
| #python | `70.65% <ø> (?)` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyLmpzeA==) | `56.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.02% <25.00%> (-3.87%)` | :arrow_down: |
| [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4) | `65.95% <50.00%> (-1.49%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `78.57% <63.63%> (-2.79%)` | :arrow_down: |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `88.67% <0.00%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `89.42% <0.00%> (ø)` | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `72.41% <0.00%> (ø)` | |
| [superset/models/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (ø)` | |
| ... and [177 more](https://codecov.io/gh/apache/incubator-superset/pull/9210/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=footer). Last update [865a909...e978f7a](https://codecov.io/gh/apache/incubator-superset/pull/9210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-621161850
> @oashton I wonder if something went wrong in the rebase? This is showing 520 files changed with `+66,552 −33,417` rows changed.
@villebro , yes... I'm gonna fix it... I'll let you know as soon as a finish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-646950596
Adding 0.37 label to this. @etr2460 is this ok to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] oashton commented on pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
oashton commented on pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210#issuecomment-624029921
Closed / reopened to restart stuck CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] suddjian merged pull request #9210: Add maximize and minimize feature to charts
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #9210:
URL: https://github.com/apache/incubator-superset/pull/9210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org