You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/09 09:30:41 UTC

[GitHub] [camel-quarkus] johnpoth commented on issue #524: refactor FHIR integration tests

johnpoth commented on issue #524: refactor FHIR integration tests
URL: https://github.com/apache/camel-quarkus/pull/524#issuecomment-563143793
 
 
   @lburgazzoli the `EnabledIfCondition` rocks ! Much needed in the FHIR integration tests and I think it will be useful for other complex extensions.
   
   I like the idea of using `testcontainers` as it is a lot simpler to start/stop the hapi server for surefire tests. It also uses an annotation which simplifies the pom and makes the test class more self contained. The small price to pay is that you need to start the HAPI server for all tests. So +1
   
   I also like the way you're configuring the component through the bean rather than the long URI I was using :)
   
   besides CAMEL-14268 this is a big + 1 , Thanks !
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services