[jira] [Commented] (HBASE-25680) Non-idempotent test in TestReplicationHFileCleaner

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-25680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399182#comment-17399182 ] 

Hudson commented on HBASE-25680:
--------------------------------

Results for branch master
	[build #367 on builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/367/]: (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/367/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/367/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/367/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Non-idempotent test in TestReplicationHFileCleaner
> --------------------------------------------------
>
>                 Key: HBASE-25680
>                 URL: https://issues.apache.org/jira/browse/HBASE-25680
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Zhengxi Li
>            Assignee: Zhengxi Li
>            Priority: Minor
>             Fix For: 2.5.0, 3.0.0-alpha-2, 2.4.6, 2.3.7
>
>         Attachments: HBASE-25680.master.001.patch
>
>
> The test *{{org.apache.hadoop.hbase.master.cleaner.TestReplicationHFileCleaner.testIsFileDeletable}}* is not idempotent and fail if run twice in the same JVM, because it pollutes some states shared among tests. It may be good to clean this state pollution so that some other tests do not fail in the future due to the shared state polluted by this test.
> h3. Detail
> Running {{TestReplicationHFileCleaner.testIsFileDeletable}} twice would result in the second run failing due to the following assertion error:
> {noformat}
> java.lang.AssertionError: Cleaner should allow to delete this file as there is 
> no hfile reference node for it in the queue.
> {noformat}
> The root cause is that the a hfile reference is added during the first test run, which doesn't get removed upon test exits. Therefore, in the second test run , {{cleaner.isFileDeletable(fs.getFileStatus(file)))}} would return {{false}}, resulting in the assertion error.
>  
> PR link: https://github.com/apache/hbase/pull/2984



--
This message was sent by Atlassian Jira
(v8.3.4#803005)