[GitHub] [spark] sachinaraballi commented on a change in pull request #29174: Addition of missing EXECUTOR_INSTANCES configuration key

[GitBox <gi...@apache.org>]

sachinaraballi commented on a change in pull request #29174:
URL: https://github.com/apache/spark/pull/29174#discussion_r457841580



##########
File path: launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java
##########
@@ -70,6 +70,8 @@
   public static final String EXECUTOR_EXTRA_JAVA_OPTIONS = "spark.executor.extraJavaOptions";
   /** Configuration key for the executor native library path. */
   public static final String EXECUTOR_EXTRA_LIBRARY_PATH = "spark.executor.extraLibraryPath";
+  /** Configuration key for the number of executor instances. */
+  public static final String EXECUTOR_INSTANCES = "spark.executor.instances";

Review comment:
       Actually in my scenario 
   ```
   sparkLauncher.setConf("spark.executor.instances", executors);
   sparkLauncher.setConf(SparkLauncher.EXECUTOR_MEMORY, executorMemory);
   sparkLauncher.setConf(SparkLauncher.DRIVER_MEMORY, driverMemory );
   sparkLauncher.setConf(SparkLauncher.EXECUTOR_CORES, executorCores);
   ```
   There is no option in SparkLauncher for executors.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org