You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/27 19:55:02 UTC
Review Request 19743: Changed active_rules to array for easier management.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
see summary. Also added two trivial rules to check.
Diffs
-----
support/mesos-style.py 084690a207baa5d5f8f9273f10c67a642371908e
Diff: https://reviews.apache.org/r/19743/diff/
Testing
-------
? support/mesos-style.py
Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
Total errors found: 0
Thanks,
Dominic Hamon
Re: Review Request 19743: Changed active_rules to array for easier
management.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/#review38796
-----------------------------------------------------------
Bad patch!
Reviews applied: [19743]
Failed command: git apply --index 19743.patch
Error:
error: patch failed: support/mesos-style.py:130
error: support/mesos-style.py: patch does not apply
- Mesos ReviewBot
On March 27, 2014, 6:55 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19743/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary. Also added two trivial rules to check.
>
>
> Diffs
> -----
>
> support/mesos-style.py 084690a207baa5d5f8f9273f10c67a642371908e
>
> Diff: https://reviews.apache.org/r/19743/diff/
>
>
> Testing
> -------
>
> ? support/mesos-style.py
> Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
> Total errors found: 0
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19743: Changed active_rules to array for easier
management.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/#review38831
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 27, 2014, 9:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19743/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 9:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary. Also added two trivial rules to check.
>
>
> Diffs
> -----
>
> support/mesos-style.py b27e3fb9dbd72d6f0b8d6e6c6af6b7f8ec7a2351
>
> Diff: https://reviews.apache.org/r/19743/diff/
>
>
> Testing
> -------
>
> ? support/mesos-style.py
> Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
> Total errors found: 0
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19743: Changed active_rules to array for easier
management.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/
-----------------------------------------------------------
(Updated March 27, 2014, 2:35 p.m.)
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
see summary. Also added two trivial rules to check.
Diffs (updated)
-----
support/mesos-style.py b27e3fb9dbd72d6f0b8d6e6c6af6b7f8ec7a2351
Diff: https://reviews.apache.org/r/19743/diff/
Testing
-------
? support/mesos-style.py
Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
Total errors found: 0
Thanks,
Dominic Hamon
Re: Review Request 19743: Changed active_rules to array for easier
management.
Posted by Dominic Hamon <dh...@twopensource.com>.
> On March 27, 2014, 12:36 p.m., Vinod Kone wrote:
> > support/mesos-style.py, lines 76-77
> > <https://reviews.apache.org/r/19743/diff/1/?file=538609#file538609line76>
> >
> > just curious. what are these rules testing?
build/class checks that a full class declaration can be found. It's partly a parsing check, but it's also if you forget the last '}' or have some extra/missing braces within a class declaration.
build/deprecated checks for certain deprecated constructs like >? and <? (max and min operators).
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/#review38794
-----------------------------------------------------------
On March 27, 2014, 2:35 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19743/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 2:35 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary. Also added two trivial rules to check.
>
>
> Diffs
> -----
>
> support/mesos-style.py b27e3fb9dbd72d6f0b8d6e6c6af6b7f8ec7a2351
>
> Diff: https://reviews.apache.org/r/19743/diff/
>
>
> Testing
> -------
>
> ? support/mesos-style.py
> Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
> Total errors found: 0
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19743: Changed active_rules to array for easier
management.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19743/#review38794
-----------------------------------------------------------
support/mesos-style.py
<https://reviews.apache.org/r/19743/#comment71097>
just curious. what are these rules testing?
support/mesos-style.py
<https://reviews.apache.org/r/19743/#comment71096>
why not just
rules_filter = '--filter=-+' + ',+'.join(active_rules)
- Vinod Kone
On March 27, 2014, 6:55 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19743/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary. Also added two trivial rules to check.
>
>
> Diffs
> -----
>
> support/mesos-style.py 084690a207baa5d5f8f9273f10c67a642371908e
>
> Diff: https://reviews.apache.org/r/19743/diff/
>
>
> Testing
> -------
>
> ? support/mesos-style.py
> Checking 403 files using filter --filter=-,+whitespace/tab,+build/class,+build/deprecated
> Total errors found: 0
>
>
> Thanks,
>
> Dominic Hamon
>
>