You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/28 23:06:09 UTC
Review Request: Replicated and improved libprocess specific gtest and gmock
features from Mesos into libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10175/
-----------------------------------------------------------
Review request for mesos, Vinod Kone and Ben Mahler.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/Makefile.am 4ac9adaaeef50713f17b2c4fa379ee9d6c63c202
third_party/libprocess/include/process/gmock.hpp PRE-CREATION
third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4
third_party/libprocess/src/tests/main.cpp 52d86d37948c7bc7987d1baa1a583465f35a8015
third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
Diff: https://reviews.apache.org/r/10175/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request: Replicated and improved libprocess specific gtest and
gmock features from Mesos into libprocess.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10175/#review18524
-----------------------------------------------------------
Ship it!
third_party/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/10175/#comment38833>
Can you comment this test please?
- Ben Mahler
On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10175/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 10:06 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 4ac9adaaeef50713f17b2c4fa379ee9d6c63c202
> third_party/libprocess/include/process/gmock.hpp PRE-CREATION
> third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4
> third_party/libprocess/src/tests/main.cpp 52d86d37948c7bc7987d1baa1a583465f35a8015
> third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
>
> Diff: https://reviews.apache.org/r/10175/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Replicated and improved libprocess specific gtest and
gmock features from Mesos into libprocess.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 29, 2013, 12:29 a.m., Vinod Kone wrote:
> > third_party/libprocess/src/tests/process_tests.cpp, line 509
> > <https://reviews.apache.org/r/10175/diff/1/?file=276132#file276132line509>
> >
> > can't you do ASSERT_TRUE(pid) instead of this inverted check?
This is the style in tests.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10175/#review18485
-----------------------------------------------------------
On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10175/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 10:06 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 4ac9adaaeef50713f17b2c4fa379ee9d6c63c202
> third_party/libprocess/include/process/gmock.hpp PRE-CREATION
> third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4
> third_party/libprocess/src/tests/main.cpp 52d86d37948c7bc7987d1baa1a583465f35a8015
> third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
>
> Diff: https://reviews.apache.org/r/10175/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Replicated and improved libprocess specific gtest and
gmock features from Mesos into libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10175/#review18485
-----------------------------------------------------------
Ship it!
third_party/libprocess/src/tests/main.cpp
<https://reviews.apache.org/r/10175/#comment38777>
s/listener/ and clock test event listener/
third_party/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/10175/#comment38778>
can't you do ASSERT_TRUE(pid) instead of this inverted check?
- Vinod Kone
On March 28, 2013, 10:06 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10175/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 10:06 p.m.)
>
>
> Review request for mesos, Vinod Kone and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> third_party/libprocess/Makefile.am 4ac9adaaeef50713f17b2c4fa379ee9d6c63c202
> third_party/libprocess/include/process/gmock.hpp PRE-CREATION
> third_party/libprocess/include/process/gtest.hpp 1fd05724e36b7b5da2bd19331927c475d76ee0b4
> third_party/libprocess/src/tests/main.cpp 52d86d37948c7bc7987d1baa1a583465f35a8015
> third_party/libprocess/src/tests/process_tests.cpp 2dd139489ba42103b2320e9a51154340644c5e9c
>
> Diff: https://reviews.apache.org/r/10175/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>