You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/28 07:42:47 UTC
[GitHub] [apisix-ingress-controller] tokers opened a new issue #515: Use controller-gen to generate CRDs instead of writing them by humanbeings
tokers opened a new issue #515:
URL: https://github.com/apache/apisix-ingress-controller/issues/515
Currently, we write CRDs by ourselves, it's tedious and error-prone. We should use tools like [controller-gen](https://book.kubebuilder.io/reference/controller-gen.html) to generate them so that we can focus on the changes of go data structures, and let it do the rest jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #515: Use controller-gen to generate CRDs instead of writing them by humanbeings
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #515:
URL: https://github.com/apache/apisix-ingress-controller/issues/515#issuecomment-850306382
> To do so, we need to remove usage of:
> any type (`interface{}`), float64 (or enable `allowDangerousTypes=true` flag).
>
> And add [markers](https://book.kubebuilder.io/reference/markers.html) like [this](https://github.com/lingsamuel/apisix-ingress-controller/blob/mtls/pkg/kube/apisix/apis/config/v1/types.go#L271-L327).
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on issue #515: Use controller-gen to generate CRDs instead of writing them by hand
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on issue #515:
URL: https://github.com/apache/apisix-ingress-controller/issues/515#issuecomment-927212491
xref: https://github.com/apache/apisix-ingress-controller/pull/689#issuecomment-927212290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #515: Use controller-gen to generate CRDs instead of writing them by humanbeings
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #515:
URL: https://github.com/apache/apisix-ingress-controller/issues/515#issuecomment-850220062
@gxthrj @tao12345666333 @lingsamuel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] lingsamuel commented on issue #515: Use controller-gen to generate CRDs instead of writing them by humanbeings
Posted by GitBox <gi...@apache.org>.
lingsamuel commented on issue #515:
URL: https://github.com/apache/apisix-ingress-controller/issues/515#issuecomment-850260303
To do so, we need to remove usage of:
any type (`interface{}`), float64 (or enable `allowDangerousTypes=true` flag).
And add [markers](https://book.kubebuilder.io/reference/markers.html) like [this](https://github.com/lingsamuel/apisix-ingress-controller/blob/mtls/pkg/kube/apisix/apis/config/v1/types.go#L271-L327).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org