You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@camel.apache.org by Thomas Letsch <co...@thomas-letsch.de> on 2012/02/04 14:10:26 UTC
Bindy CSV parser uses default encoding
Hi,
the bindy csv component uses the default encoding when importing a file
Class org.apache.camel.dataformat.bindy.csv.BindyCsvDataFormat Line 115:
- InputStreamReader in = new InputStreamReader(inputStream);
+ InputStreamReader in = new InputStreamReader(inputStream,
IOConverter.getCharsetName(exchange));
the marshal method needs that probably too. This was already done for the
standard CSV component:
https://issues.apache.org/jira/browse/CAMEL-3483
Regards,
Thomas
--
View this message in context: http://camel.465427.n5.nabble.com/Bindy-CSV-parser-uses-default-encoding-tp5456136p5456136.html
Sent from the Camel - Users mailing list archive at Nabble.com.
Re: Bindy CSV parser uses default encoding
Posted by Thomas Letsch <co...@thomas-letsch.de>.
Hi Willem,
that was fast! Thanks!
R.,
Thomas
--
View this message in context: http://camel.465427.n5.nabble.com/Bindy-CSV-parser-uses-default-encoding-tp5456136p5466948.html
Sent from the Camel - Users mailing list archive at Nabble.com.
Re: Bindy CSV parser uses default encoding
Posted by Willem Jiang <wi...@gmail.com>.
FYI, I filled a JIRA[1] and already committed the patch.
[1]https://issues.apache.org/jira/browse/CAMEL-4989
On 2/4/12 9:10 PM, Thomas Letsch wrote:
> Hi,
>
> the bindy csv component uses the default encoding when importing a file
> Class org.apache.camel.dataformat.bindy.csv.BindyCsvDataFormat Line 115:
> - InputStreamReader in = new InputStreamReader(inputStream);
> + InputStreamReader in = new InputStreamReader(inputStream,
> IOConverter.getCharsetName(exchange));
>
> the marshal method needs that probably too. This was already done for the
> standard CSV component:
> https://issues.apache.org/jira/browse/CAMEL-3483
>
> Regards,
> Thomas
>
> --
> View this message in context: http://camel.465427.n5.nabble.com/Bindy-CSV-parser-uses-default-encoding-tp5456136p5456136.html
> Sent from the Camel - Users mailing list archive at Nabble.com.
>
--
Willem
----------------------------------
FuseSource
Web: http://www.fusesource.com
Blog: http://willemjiang.blogspot.com (English)
http://jnn.javaeye.com (Chinese)
Twitter: willemjiang
Weibo: willemjiang
Re: Bindy CSV parser uses default encoding
Posted by Thomas Letsch <co...@thomas-letsch.de>.
Hi Claus,
thanks for the quick reply.
Ticket https://issues.apache.org/jira/browse/CAMEL-4983 is created.
Regards,
Thomas
On 05.02.2012 10:12, Claus Ibsen wrote:
> On Sat, Feb 4, 2012 at 2:10 PM, Thomas Letsch<co...@thomas-letsch.de> wrote:
>> Hi,
>>
>> the bindy csv component uses the default encoding when importing a file
>> Class org.apache.camel.dataformat.bindy.csv.BindyCsvDataFormat Line 115:
>> - InputStreamReader in = new InputStreamReader(inputStream);
>> + InputStreamReader in = new InputStreamReader(inputStream,
>> IOConverter.getCharsetName(exchange));
>>
>> the marshal method needs that probably too. This was already done for the
>> standard CSV component:
>> https://issues.apache.org/jira/browse/CAMEL-3483
>>
> Hi
>
> Can you create a JIRA ticket for this?
>
>> Regards,
>> Thomas
>>
>> --
>> View this message in context: http://camel.465427.n5.nabble.com/Bindy-CSV-parser-uses-default-encoding-tp5456136p5456136.html
>> Sent from the Camel - Users mailing list archive at Nabble.com.
>
>
Re: Bindy CSV parser uses default encoding
Posted by Claus Ibsen <cl...@gmail.com>.
On Sat, Feb 4, 2012 at 2:10 PM, Thomas Letsch <co...@thomas-letsch.de> wrote:
> Hi,
>
> the bindy csv component uses the default encoding when importing a file
> Class org.apache.camel.dataformat.bindy.csv.BindyCsvDataFormat Line 115:
> - InputStreamReader in = new InputStreamReader(inputStream);
> + InputStreamReader in = new InputStreamReader(inputStream,
> IOConverter.getCharsetName(exchange));
>
> the marshal method needs that probably too. This was already done for the
> standard CSV component:
> https://issues.apache.org/jira/browse/CAMEL-3483
>
Hi
Can you create a JIRA ticket for this?
> Regards,
> Thomas
>
> --
> View this message in context: http://camel.465427.n5.nabble.com/Bindy-CSV-parser-uses-default-encoding-tp5456136p5456136.html
> Sent from the Camel - Users mailing list archive at Nabble.com.
--
Claus Ibsen
-----------------
FuseSource
Email: cibsen@fusesource.com
Web: http://fusesource.com
Twitter: davsclaus, fusenews
Blog: http://davsclaus.blogspot.com/
Author of Camel in Action: http://www.manning.com/ibsen/