You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "danielales2541 (via GitHub)" <gi...@apache.org> on 2025/09/11 19:57:17 UTC
[PR] FINERACT-2376: Unable to re-invest maturity amount or principal for fixed deposit at closing [fineract]
danielales2541 opened a new pull request, #5030:
URL: https://github.com/apache/fineract/pull/5030
…ixed deposit at closing
## Description
In the list of actions for closing a fixed deposit account, "Reinvest Maturity Amount" and "Reinvest Principal Only," the transaction cannot be closed due to the error: "Internal Server Error."
-This error also affects fixed deposit accounts when running the "Update Deposit Accounts Maturity Details" job.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2376: Unable to re-invest maturity amount or principal for fixed deposit at closing [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on code in PR #5030:
URL: https://github.com/apache/fineract/pull/5030#discussion_r2360759559
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/FixedDepositTest.java:
##########
@@ -2598,6 +2610,158 @@ public void testFixedDepositAccountWithRolloverPrincipal() {
FixedDepositAccountStatusChecker.verifyFixedDepositIsActive(fixedDepositAccountStatusHashMap);
}
+ @Test
+ public void testCloseFixedDepositForCLOSURE_TYPE_REINVEST_withConfigurationMaturityInstruction() {
Review Comment:
Please make sure any new test and internal API calls are using the fineract-client only! We should not write any tests which still using any of the deprecated helper methods or anything...unless it is a must!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2376: Unable to re-invest maturity amount or principal for fixed deposit at closing [fineract]
Posted by "danielales2541 (via GitHub)" <gi...@apache.org>.
danielales2541 closed pull request #5030: FINERACT-2376: Unable to re-invest maturity amount or principal for fixed deposit at closing
URL: https://github.com/apache/fineract/pull/5030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-2376: Unable to re-invest maturity amount or principal for fixed deposit at closing [fineract]
Posted by "danielales2541 (via GitHub)" <gi...@apache.org>.
danielales2541 commented on PR #5030:
URL: https://github.com/apache/fineract/pull/5030#issuecomment-3282958778
Hello @adamsaghy, could you please review the changes? The Cucumber test is failing for me; tests were already run locally and everything passed correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org