You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/09/12 18:22:45 UTC
[GitHub] [helix] jiajunwang commented on a change in pull request #468: Make
CustomRebalancer re-compute upon CurrentState and Message change
jiajunwang commented on a change in pull request #468: Make CustomRebalancer re-compute upon CurrentState and Message change
URL: https://github.com/apache/helix/pull/468#discussion_r323878190
##########
File path: helix-core/src/main/java/org/apache/helix/common/caches/InstanceMessagesCache.java
##########
@@ -113,6 +114,10 @@ public boolean refresh(HelixDataAccessor accessor, Map<String, LiveInstance> liv
String messageName = cachedNamesIter.next();
if (!messageNames.contains(messageName)) {
cachedNamesIter.remove();
+ // a removal exists
+ if (!existsChange) {
Review comment:
Why check before set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org