[jira] [Commented] (TEZ-3767) Shuffle should not report error to AM during inputContext.killSelf()

["TezQA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-3767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16057054#comment-16057054 ] 

TezQA commented on TEZ-3767:
----------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment
  http://issues.apache.org/jira/secure/attachment/12873800/TEZ-3767.1.patch
  against master revision a925c83.

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 3.0.1) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TEZ-Build/2528//testReport/
Console output: https://builds.apache.org/job/PreCommit-TEZ-Build/2528//console

This message is automatically generated.

> Shuffle should not report error to AM during inputContext.killSelf()
> --------------------------------------------------------------------
>
>                 Key: TEZ-3767
>                 URL: https://issues.apache.org/jira/browse/TEZ-3767
>             Project: Apache Tez
>          Issue Type: Bug
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>         Attachments: TEZ-3767.1.patch
>
>
> {{ShuffleScheduler::killSelf}} kills the current attempt when it encounters certain errors. As a part of cleanup, it invokes {{close}} which internally releases the resources.
> If merge is happening in the middle,  it could throw the following exception. This is caught in {{RunShuffleCallable}} and reported to AM immediately. This causes tasks to fail.
> {noformat}
> » Error: Error while running task ( failure ) : org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle$ShuffleError: Error while doing final merge 
>   at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle$RunShuffleCallable.callInternal(Shuffle.java:320)
>   at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle$RunShuffleCallable.callInternal(Shuffle.java:285)
>   at org.apache.tez.common.CallableWithNdc.call(CallableWithNdc.java:36)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:748)
> Caused by: java.util.ConcurrentModificationException
>   at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1211)
>   at java.util.TreeMap$KeyIterator.next(TreeMap.java:1265)
>   at java.util.AbstractCollection.toArray(AbstractCollection.java:141)
>   at java.util.ArrayList.addAll(ArrayList.java:577)
>   at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.MergeManager.close(MergeManager.java:636)
>   at org.apache.tez.runtime.library.common.shuffle.orderedgrouped.Shuffle$RunShuffleCallable.callInternal(Shuffle.java:316)
>   ... 6 more
> {noformat}
> When {{isShutDown}} is set to true, it would be good to avoid sending error messages to AM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)