You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/06/01 12:43:13 UTC

[GitHub] [arrow-datafusion] alamb opened a new issue, #6513: Replace AbortOnDrop / AbortDropOnMany with tokio `JoinSet`

alamb opened a new issue, #6513:
URL: https://github.com/apache/arrow-datafusion/issues/6513

   TDLR is that ensuring that launched tasks are properly cleaned up (and `panic`s are propagated back to the main tasks) is tricky.
   
   Tokio has a [tokio::task::JoinSet](https://docs.rs/tokio/latest/tokio/task/struct.JoinSet.html) which handles the cleanup part and https://github.com/apache/arrow-datafusion/pull/6507 demonstrates how to use JoinSet to propagate panics. 
   
   We should ideally also fix 
    `datafusion/core/src/physical_plan/repartition/mod.rs` to propagate panics
   and remove  `AbortOnDrop` and`AbortOnDropMany` with JoinSet
   
   _Originally posted by @crepererum in https://github.com/apache/arrow-datafusion/issues/6449#issuecomment-1568326616_
               


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Replace AbortOnDrop / AbortDropOnMany with tokio `JoinSet` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #6513: Replace AbortOnDrop / AbortDropOnMany with tokio `JoinSet`
URL: https://github.com/apache/arrow-datafusion/issues/6513


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org