[GitHub] [iceberg] szehon-ho commented on a diff in pull request #4637: Core: Fix Partitions table filtering for evolved partition specs

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #4637:
URL: https://github.com/apache/iceberg/pull/4637#discussion_r861386968


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -149,14 +150,15 @@ static CloseableIterable<FileScanTask> planFiles(StaticTableScan scan) {
     Snapshot snapshot = table.snapshot(scan.snapshot().snapshotId());
     boolean caseSensitive = scan.isCaseSensitive();
 
-    // use an inclusive projection to remove the partition name prefix and filter out any non-partition expressions
-    Expression partitionFilter = Projections
-        .inclusive(transformSpec(scan.schema(), table.spec()), caseSensitive)
-        .project(scan.filter());
+    LoadingCache<Integer, ManifestEvaluator> evalCache = Caffeine.newBuilder().build(specId -> {

Review Comment:
   Discussed, at this point we keep all partition specs so this will save a cycle if we have some spec without any manifests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org