You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/22 03:11:12 UTC
[GitHub] [cloudstack] utchoang opened a new pull request #4716: guestnetwork: Add guest IP ranges
utchoang opened a new pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-783113223
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785555763
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3844)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785538685
@rhtyd In the traffic type tab, if guest network is a `Isolated | L2` then will not have router-link?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785554130
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-784995703
@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785541796
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785553705
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang removed a comment on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
utchoang removed a comment on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785538685
@rhtyd In the traffic type tab, if guest network is a `Isolated | L2` then will not have router-link?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785617444
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785026449
@utchoang can you address:
- Fix the tab to be only shown for shared networks, it's showing for L2 as well (ex. http://qa.cloudstack.cloud:8080/client/pr/4716/#/guestnetwork/6463e120-c36a-4569-aaa7-729922a55825?tab=guest.ip.range)
- When we go to Infra -> zones -> phy network -> traffic type -> add router-link in the network name (for ex. http://qa.cloudstack.cloud:8080/client/pr/4716/#/physicalnetwork/d3249fba-8282-4ede-823c-2c1393bff05b?tab=traffic.types)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785544090
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3842)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785617757
@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. [S]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-783113851
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785542295
@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-785620629
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (SL-JID-14)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-784994875
@blueorangutan ui
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-784999443
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3841)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-783116660
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4716 (JID-3839)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4716: ui: Add guest IP ranges
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4716:
URL: https://github.com/apache/cloudstack/pull/4716#issuecomment-786031322
LGTM tested the live URL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org