[GitHub] [helix] xyuanlu commented on a diff in pull request #2249: Add listener interfaces and config class

[GitBox <gi...@apache.org>]

xyuanlu commented on code in PR #2249:
URL: https://github.com/apache/helix/pull/2249#discussion_r1011027232


##########
meta-client/src/main/java/org/apache/helix/metaclient/api/PersistSubEntryChangeListener.java:
##########
@@ -0,0 +1,40 @@
+package org.apache.helix.metaclient.api;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/*
+ * Listener interface for children change events on a particular key. It includes new subentry
+ * creation, subentry deletion, subentry data change and when the listener is removed.
+ * This listener type can only be registered as a persist listener.
+ * For hierarchy key spaces like zookeeper, it refers to an entry's entire subtree.

Review Comment:
   TFTR. Current Zookeeper support recursive watcher. ZkMetaClient uses ZkClient underlying and we may add recursive children listener if needed. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org