[GitHub] [calcite] amaliujia commented on a change in pull request #2320: [CALCITE-4458] The "rowTypeCoercion" for "SET" operations should be "OR" relationship (Jiatao Tao)

[GitBox <gi...@apache.org>]

amaliujia commented on a change in pull request #2320:
URL: https://github.com/apache/calcite/pull/2320#discussion_r566366088



##########
File path: core/src/main/java/org/apache/calcite/sql/validate/implicit/TypeCoercionImpl.java
##########
@@ -122,7 +122,7 @@ public TypeCoercionImpl(RelDataTypeFactory typeFactory, SqlValidator validator)
       final SqlCall operand0 = ((SqlCall) query).operand(0);
       final SqlCall operand1 = ((SqlCall) query).operand(1);
       final boolean coerced = rowTypeCoercion(scope, operand0, columnIndex, targetType)
-          && rowTypeCoercion(scope, operand1, columnIndex, targetType);
+          || rowTypeCoercion(scope, operand1, columnIndex, targetType);
       // Update the nested SET operator node type.

Review comment:
       @Aaaaaaron  any update on the test in `TypeCoercionTest#testSetOperations`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org