You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by cs...@apache.org on 2020/07/16 12:18:50 UTC

[activemq] branch master updated (17defa7 -> 6c0cb41)

This is an automated email from the ASF dual-hosted git repository.

cshannon pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/activemq.git.


    from 17defa7  NO-JIRA: Update branch to 5.17.0-SNAPSHOT after release
     new 871654d  Change org.apache.activemq.jms.pool.XaPooledConnectionFactory#tmFromJndi parameter to Boolean for JCA validation
     new 295b3ac  AMQ-7516 - Merge branch
     new 6c0cb41  AMQ-7516 - Fix XAConenctionPoolTest after change to make tmFromJndi an object

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .../org/apache/activemq/jms/pool/XaPooledConnectionFactory.java     | 6 +++---
 .../java/org/apache/activemq/jms/pool/XAConnectionPoolTest.java     | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)


[activemq] 03/03: AMQ-7516 - Fix XAConenctionPoolTest after change to make tmFromJndi an object

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

cshannon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq.git

commit 6c0cb4143d929b506a26e57267399b606396fbba
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
AuthorDate: Thu Jul 16 08:18:01 2020 -0400

    AMQ-7516 - Fix XAConenctionPoolTest after change to make tmFromJndi an
    object
---
 .../test/java/org/apache/activemq/jms/pool/XAConnectionPoolTest.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/XAConnectionPoolTest.java b/activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/XAConnectionPoolTest.java
index d793759..a4ea122 100644
--- a/activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/XAConnectionPoolTest.java
+++ b/activemq-jms-pool/src/test/java/org/apache/activemq/jms/pool/XAConnectionPoolTest.java
@@ -322,8 +322,8 @@ public class XAConnectionPoolTest extends JmsPoolTestSupport {
     public void testBindableEnvOverrides() throws Exception {
         XaPooledConnectionFactory pcf = new XaPooledConnectionFactory();
         assertTrue(pcf instanceof ObjectFactory);
-        Hashtable<String, String> environment = new Hashtable<String, String>();
-        environment.put("tmFromJndi", String.valueOf(Boolean.FALSE));
+        Hashtable<String, Object> environment = new Hashtable<>();
+        environment.put("tmFromJndi", Boolean.FALSE);
         assertTrue(((ObjectFactory) pcf).getObjectInstance(null, null, null, environment) instanceof XaPooledConnectionFactory);
         assertFalse(pcf.isTmFromJndi());
         pcf.stop();


[activemq] 02/03: AMQ-7516 - Merge branch

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

cshannon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq.git

commit 295b3acb9e2ebf0e4ae8a4cfc811f41ef85fc184
Merge: 17defa7 871654d
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
AuthorDate: Thu Jul 16 08:10:59 2020 -0400

    AMQ-7516 - Merge branch
    
    This closes #286

 .../org/apache/activemq/jms/pool/XaPooledConnectionFactory.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)


[activemq] 01/03: Change org.apache.activemq.jms.pool.XaPooledConnectionFactory#tmFromJndi parameter to Boolean for JCA validation

Posted by cs...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

cshannon pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/activemq.git

commit 871654ded6ceed2781331a0be6b977bacba6c094
Author: Tomasz Adamski <ta...@redhat.com>
AuthorDate: Wed Jul 11 21:01:30 2018 +0200

    Change org.apache.activemq.jms.pool.XaPooledConnectionFactory#tmFromJndi parameter to Boolean for JCA validation
---
 .../org/apache/activemq/jms/pool/XaPooledConnectionFactory.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/XaPooledConnectionFactory.java b/activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/XaPooledConnectionFactory.java
index a5d5aea..dd4f962 100644
--- a/activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/XaPooledConnectionFactory.java
+++ b/activemq-jms-pool/src/main/java/org/apache/activemq/jms/pool/XaPooledConnectionFactory.java
@@ -43,7 +43,7 @@ public class XaPooledConnectionFactory extends PooledConnectionFactory implement
     private static final long serialVersionUID = -6545688026350913005L;
 
     private TransactionManager transactionManager;
-    private boolean tmFromJndi = false;
+    private Boolean tmFromJndi = false;
     private String tmJndiName = "java:/TransactionManager";
 
     public TransactionManager getTransactionManager() {
@@ -129,7 +129,7 @@ public class XaPooledConnectionFactory extends PooledConnectionFactory implement
         this.tmJndiName = tmJndiName;
     }
 
-    public boolean isTmFromJndi() {
+    public Boolean isTmFromJndi() {
         return tmFromJndi;
     }
 
@@ -138,7 +138,7 @@ public class XaPooledConnectionFactory extends PooledConnectionFactory implement
      *
      * @param tmFromJndi
      */
-    public void setTmFromJndi(boolean tmFromJndi) {
+    public void setTmFromJndi(Boolean tmFromJndi) {
         this.tmFromJndi = tmFromJndi;
     }
 }