You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "rreddy-22 (via GitHub)" <gi...@apache.org> on 2025/06/17 01:46:03 UTC

[PR] KAFKA-19367: Follow up bug fix [kafka]

rreddy-22 opened a new pull request, #19976:
URL: https://github.com/apache/kafka/pull/19976

   This is a follow up to [https://github.com/apache/kafka/pull/19910](url)
   `The coordinator failed to write an epoch fence transition for producer jt142 to the transaction log with error COORDINATOR_NOT_AVAILABLE. The epoch was increased to 2 but not returned to the client (kafka.coordinator.transaction.TransactionCoordinator)` -- as we don't bump the epoch with this change, we should also update the message to not say "increased" and remove the **epochAndMetadata.transactionMetadata.hasFailedEpochFence = true** line
   
   In the test the expected behavior is:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19367: Follow up bug fix [kafka]

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan commented on code in PR #19976:
URL: https://github.com/apache/kafka/pull/19976#discussion_r2152736969


##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -977,10 +977,9 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
 
                   case Some(epochAndMetadata) =>
                     if (epochAndMetadata.coordinatorEpoch == coordinatorEpoch) {
-                      // This was attempted epoch fence that failed, so mark this state on the metadata
-                      epochAndMetadata.transactionMetadata.hasFailedEpochFence = true
+                      // For TV2, we allow re-bumping the epoch on retry, so don't set hasFailedEpochFence = true

Review Comment:
   For this comment, should we say that we don't complete the epoch bump so we can simply retry the epoch bump.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-19367: Follow up bug fix [kafka]

Posted by "jolshan (via GitHub)" <gi...@apache.org>.
jolshan merged PR #19976:
URL: https://github.com/apache/kafka/pull/19976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org