You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/12/05 21:46:45 UTC

[kudu-CR] tablet copy client-test: have servers use same number of dirs

Hello Will Berkeley, Mike Percy, Kudu Jenkins, Hao Hao, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8767

to look at the new patch set (#3).

Change subject: tablet_copy_client-test: have servers use same number of dirs
......................................................................

tablet_copy_client-test: have servers use same number of dirs

The test copies a block from one server to another. Before doing so, the
copy client ensures that the block it's about to copy over does not
exist in the current FS, and doing so entails doing a block lookup.

The problem is that since 8a81f4ff18ee30951a25bab247fa5a3c20058e49, the
client's local FS has two data directories, while the source tablet
server has three.

When running with --block_manager=file, block IDs are prefixed with the
index of the directory they are in. This is problematic because for
safety, block lookups DCHECK that the index of the block makes sense
with the number of data directories. Given the mentioned configurations,
when looking up a block in the third directory from the source tserver,
the local FS would hit the DCHECK.

The solution in this patch is to make the number of directories in the
local FS equal the number of directories in the remote tserver.

Change-Id: I4c65a10a2a0f32ad0ecb467073dbec9965d2b093
---
M src/kudu/tserver/tablet_copy-test-base.h
M src/kudu/tserver/tablet_copy_client-test.cc
2 files changed, 13 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/8767/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8767
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4c65a10a2a0f32ad0ecb467073dbec9965d2b093
Gerrit-Change-Number: 8767
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>