You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Kim van der Riet (JIRA)" <ji...@apache.org> on 2018/07/16 17:13:00 UTC

[jira] [Resolved] (QPIDIT-128) misuse of JAVA_HOME causes tests to error without clear indication why

     [ https://issues.apache.org/jira/browse/QPIDIT-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kim van der Riet resolved QPIDIT-128.
-------------------------------------
    Resolution: Fixed

I have made the changes in this Jira so that JAVA_HOME defaults to /usr on Linux systems, and hence the java executable can be found at ${JAVA_HOME}/bin. However, this does not change the error message that is seen in the event the jar file containing the shims is not found. I have added an error message to the test itself that will print if the jar is not found.

> misuse of JAVA_HOME causes tests to error without clear indication why
> ----------------------------------------------------------------------
>
>                 Key: QPIDIT-128
>                 URL: https://issues.apache.org/jira/browse/QPIDIT-128
>             Project: Apache QPID Interoperability Test Suite
>          Issue Type: Bug
>          Components: Qpid Jms Shim
>    Affects Versions: 0.1.0, 0.2.0
>            Reporter: Robbie Gemmell
>            Assignee: Kim van der Riet
>            Priority: Critical
>             Fix For: 0.2.0
>
>
> The interop suite misuses JAVA_HOME, and in doing so Python tries to run java from the wrong place. This results in the tests erroring out with note of a file not found, but with no indication what file wasn't found. Resorting to some prints for debugging, it emerges that Python is being asked to run Java with the wrong location
> JAVA_HOME points to the root of the java installation, with the java command and various others then found in the bin subdir. The interop tests currently omit the bin subdir when JAVA_HOME was actually defined, but do include it (via a fragile and debatable hard coded default) when JAVA_HOME is not defined:
> {noformat}
> JAVA_HOME = os.getenv('JAVA_HOME', '/usr/bin') # Default only works in Linux
> JAVA_EXEC = os.path.join(JAVA_HOME, 'java')
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org