You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2012/06/21 00:05:42 UTC

[jira] [Created] (GIRAPH-209) Include munge version in artifact name

Jakob Homan created GIRAPH-209:
----------------------------------

             Summary: Include munge version in artifact name
                 Key: GIRAPH-209
                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
             Project: Giraph
          Issue Type: Bug
            Reporter: Jakob Homan
            Priority: Blocker


Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-6.patch

fixed, tested on a number of profiles, seems to work fine. Now the -Dhadoop=... option is not the way to select a profile, the -P option is again functional using the proper profile names like:

mvn -Phadoop_trunk clean package

etc.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429406#comment-13429406 ] 

Hudson commented on GIRAPH-209:
-------------------------------

Integrated in Giraph-trunk-Commit #156 (See [https://builds.apache.org/job/Giraph-trunk-Commit/156/])
    GIRAPH-209. Include munge version in artifact name. Contributed by Eli Reisman. (Revision 1369994)

     Result = SUCCESS
jghoman : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1369994
Files : 
* /giraph/trunk/CHANGELOG
* /giraph/trunk/pom.xml

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch, GIRAPH-209-7.patch, GIRAPH-209-8.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan reassigned GIRAPH-209:
----------------------------------

    Assignee: Eli Reisman
    
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405109#comment-13405109 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

Again, please do not remove earlier patches.  They're helpful in tracking changes.  JIRA greys out all but the latest patch so there is no confusion.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-3.patch

This should fix all the issues with the old one. Using -Dhadoop=<PROFILE_ID>  with mvn seems to build the correct .tar.gz and jar-with-dependencies and fixes the naming, and all this passes mvn verify. I was told the -P mvn option was not the way to do this anymore (the -Dhadoop=... is what I was told to use) so I only verified that the -D style profile selection works.


                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-2.patch

This one works, even if no -Dhadoop=... is specified, and it includes a "for-hadoop-" clause so you can see what it all means. Perhaps at some point we can abbreviate the -with-dependencies part as the names are getting bit long. But this is much clearer I think.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-1.patch, GIRAPH-209-2.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-5.patch

This version is a simpler solution, is up to date with changes in the codebase and ready to commit. For various reasons, setting the -Dhadoop=... setting does not seem to affect the build. by moving the hadoop.version from the default props into the default profile (it already has a setting in each alternate munge profile) you can now select any munge version at mvn command line with -P<PROFILE_NAME> and I know it works because my mvn repo downloads the new jars to build it. Now, no matter which profile you select when doing a build, the giraph tar.gz and the jar with dependencies gets built with its old name + "for-hadoop-${hadoop.version}" inserted, so you always know which version of Hadoop to run it against. This is important because most of the profiles depend on knowing that tidbit of data, knowing the mvn profile name is of little use to new Giraph users who want to try a given Giraph build on their Hadoop cluster and don't know if it is compatible or not. This has been tested with a bunch of the profiles and builds fine. The only changes were a couple to the pom.xml, assembly.xml and compile.xml

ready to commit, as far as I can see, please try this out and let me know what you think. 
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-4.patch

added the ${basedir}/target/...

to line 654 of the top-level POM.xml so that when Eugene's GIRAPH-212 patch gets committed to fix secure version, this will integrate smoothly. Passes all mvn verify, seems to work with -Dhadoop=... and -P profile options. So this seems to be the right patch to get this closed out at this point.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428517#comment-13428517 ] 

Eli Reisman commented on GIRAPH-209:
------------------------------------

those are source, tests and jdocs, not specific to a version of hadoop. All of my tests with -P options (including default of no -P) came out with the fat jar and tar.gz were marked with hadoop versions, are you not having that result? If not, I can fix this.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400984#comment-13400984 ] 

Eli Reisman commented on GIRAPH-209:
------------------------------------

the munge string I am using is just the ${hadoop} var thats already there, if the user chooses not to set it, it uses the standard naming scheme as it is. I assumed if you know to set -Dhadoop=... then you know what its for or why. What should I use as a sub?


                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-1.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428493#comment-13428493 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

Looking good but not all the jars are tagged:
{noformat}209> ls -lh target/giraph-0.2-SNAPSHOT*.jar
target/giraph-0.2-SNAPSHOT-for-hadoop-0.23.1-jar-with-dependencies.jar
target/giraph-0.2-SNAPSHOT-javadoc.jar
target/giraph-0.2-SNAPSHOT-sources.jar
target/giraph-0.2-SNAPSHOT-tests.jar
target/giraph-0.2-SNAPSHOT.jar{noformat}
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-1.patch

this passes 'mvn verify', and my own eyeballs. appends to .jar and .tar.gz files in target/ to let user know which version was built, set by profile selection a la:

mvn -Dhadoop=<PROFILE> ...


                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>         Attachments: GIRAPH-209-1.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402445#comment-13402445 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

Looking good.
* Values are coming out with "for hadoop" with just "for, eg giraph-0.2-SNAPSHOT-for-1.0-bin.tar.gz 
* Rather than putting default into the name we can explicitly call out the value (0.203)
* It looks like the munged jar isn't getting named.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-1.patch, GIRAPH-209-2.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment:     (was: GIRAPH-209-2.patch)
    
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407708#comment-13407708 ] 

Eli Reisman commented on GIRAPH-209:
------------------------------------

sorry I won't do that any more. I was unsure if I had named the same one twice, wanted to make it clear what was what because the old one was not working. Totally understand. Incidentally, this one is ready to go if you think it does what we want it to.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400873#comment-13400873 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

* Without specifying a hadoop version the output ends up looking like:  
* When specifying the hadoop, we just end up with the value passed: giraph-0.2-SNAPSHOT-1.0-jar-with-dependencies.jar.  Maybe be more explicit name: giraph-0.2-SNAPSHOT-for-hadoop-1.0-jar-with-dependencies.jar?
* It will probably be easier to define the munge string once and then refer to it in the other locations in the file.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-1.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405104#comment-13405104 ] 

Eli Reisman commented on GIRAPH-209:
------------------------------------

I deleted the 2 earlier patches as they don't reflect the change to .jar moving to the top-level dir in the .tar.gz this one should encompass that recent change as well.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment:     (was: GIRAPH-209-1.patch)
    
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Homan updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-8.patch

+1 except it turns out the trunk profile only works because we all happen to have those hadoop artifacts in our local repos.  I've added the apache repos into the pom so we can pull those artifacts in directly.  Will commit shortly.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch, GIRAPH-209-7.patch, GIRAPH-209-8.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428331#comment-13428331 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

Stale.  Please update.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Avery Ching (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399441#comment-13399441 ] 

Avery Ching commented on GIRAPH-209:
------------------------------------

Good idea.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>            Reporter: Jakob Homan
>            Priority: Blocker
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429344#comment-13429344 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

Submitting patch so it's picked up in the to-be-reviewed queue.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch, GIRAPH-209-7.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Jakob Homan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403362#comment-13403362 ] 

Jakob Homan commented on GIRAPH-209:
------------------------------------

Is there a new patch since the review? I don't see it.
                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-1.patch, GIRAPH-209-2.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eli Reisman updated GIRAPH-209:
-------------------------------

    Attachment: GIRAPH-209-7.patch

This one works, renames all artifacts properly for all profiles, makes -P option work again instead of using -D to select build profile.

passes mvn verify, various profile builds.

Incidentally, there is an unrelated bug in the facebook build I have been having trouble with on trunk and still happens with this patch involving ${hadoop.jar.path} POM variable. Is there a separate JIRA up on this or should I start one? I figured one of the FB folks would want to take a crack at this and I left it alone.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch, GIRAPH-209-5.patch, GIRAPH-209-6.patch, GIRAPH-209-7.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (GIRAPH-209) Include munge version in artifact name

Posted by "Eli Reisman (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GIRAPH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411732#comment-13411732 ] 

Eli Reisman commented on GIRAPH-209:
------------------------------------

This patch has gone stale, let me upload a new one.

                
> Include munge version in artifact name
> --------------------------------------
>
>                 Key: GIRAPH-209
>                 URL: https://issues.apache.org/jira/browse/GIRAPH-209
>             Project: Giraph
>          Issue Type: Bug
>    Affects Versions: 0.2.0
>            Reporter: Jakob Homan
>            Assignee: Eli Reisman
>            Priority: Blocker
>              Labels: patch
>             Fix For: 0.2.0
>
>         Attachments: GIRAPH-209-3.patch, GIRAPH-209-4.patch
>
>
> Right now, regardless of what munge parameter is passed in, the result jar and .tar.gz is just called giraph, meaning one can't know if one has the munged version one wants or even what one really has.  The artifacts should include the munging identifier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira